fix: wrong value of has_py3_only_sources in the PyInfo constructor
#3315
Conversation
Summary of ChangesHello @oprypin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a bug in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This PR correctly fixes a copy-paste error in the _PyInfo_init function, ensuring has_py3_only_sources is assigned the correct value. I've added a comment suggesting to also fix a related bug in the test suite to ensure this change is properly verified.
Additionally, while reviewing _PyInfo_init, I noticed another potential copy-paste error in the argument type checks on lines 136-137 of python/private/py_info.bzl. The checks for transitive_implicit_pyc_files and transitive_implicit_pyc_source_files both incorrectly use transitive_pyc_files as the variable being checked. You may want to address this in a separate change.
The has_py3_only_sources field was being set to the has_py2_only_sources variable